UI Switch - Dynamic properties #1227
Conversation
There was a problem hiding this comment.
@bartbutenaers thanks a lot for improvement of this widget
Dynamic properties are working as expected and the docs also looks good.
Screen.Recording.2024-08-26.at.11.09.20.mov
Overall PR looks good to me.
@joepavitt are we setting Passthru as a dynamic property #1181. It's not implemented other widgets at the moment
| @@ -113,7 +136,7 @@ export default { | |||
| }, | |||
| toggle () { | |||
| if (this.state.enabled) { | |||
| if (this.props.decouple) { | |||
| if (this.getProperty('decouple')) { | |||
There was a problem hiding this comment.
Better to move this to a computed property and refer it here as a readability improvement. But we can do that later
computed: {
decouple () {
return this.getProperty('decouple')
}
}
There was a problem hiding this comment.
are we setting Passthru as a dynamic property #1181. It's not implemented other widgets at the moment
It wasn't a priority in others, switch is used in different ways where having this would be useful. Not goign to push it away if it's already been implemented!
There was a problem hiding this comment.
Thanks for the feedback Joe. I will check this separately
|
Hi @joepavitt, @joepavitt, |
Description
This PR allows the properties of a ui-switch to be dynamically updated via input messages:
msg.ui_update.labelmsg.ui_update.passthrumsg.ui_update.decouplemsg.ui_update.oncolormsg.ui_update.offcolormsg.ui_update.oniconmsg.ui_update.officonExample flow
TODO's
When I first saw the "Indicator" property in the config screen this week, I thought that it was only about the node status label. But it seems that there is a quite simple but powerfull mechanism involved behind the scenes. I really like the simplicity of the design! But it is not clear what this property is really doing, by simply looking at the config screen. So I suggest to update the documenation.
Moreover the property is named "Indicator" on the config screen. On the other hand, the corresponding node property is
decouple. First at all I find it confusing that the dynamic property has a different name as in the config screen. Imho I would call it also 'Decouple' on the config screen, because it is in fact a decoupling mechanism.I think this is the summary:
But since I am not native english speaking you guys might perhaps have better descriptions for this...
Related Issue(s)
See #1181
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel